Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516337 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-08-21 05:39:42 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1619853 + rpmlint is silent for SRPM and for RPM. + source files match upstream url f9ca4403d02ecbe819a5f69fe4afcc0ab141398e Devel-LeakGuard-Object-0.06.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=6, Tests=60, 0 wallclock secs ( 0.03 usr 0.03 sys + 0.28 cusr 0.03 csys = 0.37 CPU) + Package perl-Devel-LeakGuard-Object-0.06-1.fc12.noarch => Provides: perl(Devel::LeakGuard::Object) = 0.06 perl(Devel::LeakGuard::Object::State) = 0.06 Requires: perl >= 0:5.008 perl(Carp) perl(Data::Dumper) perl(Devel::LeakGuard::Object) perl(Devel::LeakGuard::Object::State) perl(Devel::Peek) perl(List::Util) perl(Scalar::Util) perl(base) perl(strict) perl(warnings) + Not a GUI application Suggestions: 1) license should be "GPLv2+ or artistic" as per LICENSE file APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review