Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509933 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-08-05 21:36:25 EDT --- It's odd that rpm doesn't generate a python(abi) dependency for this package, but I guess that's because the modules aren't in the usual location for python modules. I don't think that causes any problems, because as far as I know even the .pyc and .pyo files are compatible between python versions. Otherwise, this builds fine and rpmlint is silent. The web site is a little sparse but I assume someone will take care of that as the software is developed further. I don't see any issues with the package. * source files match upstream. sha256sum: e70e8fa4cf67467f9ad90be0ee92479234e594306a638cc548c4150af96b189c chameleon-0.2.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: chameleon = 0.2-1.fc12 = /usr/bin/env python >= 2.3 python-ply * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review