Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gdal - A translator library for raster geospatial data formats https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205955 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-09-12 12:06 EST ------- Before checking 1.3.2-2: (In reply to comment #3) > > * BuildRequires: > > - libjpeg-devel, zlib-devel, netcdf-devel <- required by hdf-devel > > (ditto requires for -devel package) > > I am unsure what you mean with this one. Afaik all BuildRequires are allready > present in the spec file. I meant that: "libjpeg-devel, zlib-devel, netcdf-devel" is required by hdf-devel, so adding "libjpeg-devel, zlib-devel, netcdf-devel" for BuildRequires (or Requires on -devel package) is unnecessary because hdf-devel pulls them anyway. > > > * Encoding > > - Several text files are encoded in ISO-8859. Change the encoding > > to UTF-8 unless it is necessary. > Could you give me some examples? Well, gdal-1.3.2-1/usr/share/gdal/cubewerx_extra.wkt: ISO-8859 English text, with very long lines gdal-1.3.2-1/usr/share/gdal/s57expectedinput.csv: ISO-8859 English text gdal-1.3.2-1/usr/share/gdal/prime_meridian.csv: ISO-8859 text gdal-debuginfo-1.3.2-1/usr/src/debug/gdal-1.3.2/frmts/rmf/rmfdataset.cpp: ISO-8859 English text gdal-devel-1.3.2-1/usr/include/gdal/cpl_win32ce_api.h: ISO-8859 English text gdal-devel-1.3.2-1/usr/include/gdal/cpl_wince.h:ISO-8859 English text Also, one file has wrong end-of-line encoding. gdal-debuginfo-1.3.2-1/usr/src/debug/gdal-1.3.2/frmts/nitf/nitffile.c: ASCII English text, with CRLF, LF line terminators > > - ./gdal-1.3.2-1/usr/share/gdal/seed_2d.dgn: Microstation > > ./gdal-1.3.2-1/usr/share/gdal/seed_3d.dgn: data > > Well, what are these files? I simply want to know what these files are. done > > One major issue I still have is with some programs in the *-bin package: > > $ gdalinfo > mkdir: cannot create directory `/usr/bin/.libs': Permission denied > /usr/bin/ld: cannot open output file /usr/bin/.libs/22786-lt-gdalinfo: No such > file or directory > collect2: ld returned 1 exit status > I will check this after. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review