Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=514351 --- Comment #2 from Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> 2009-08-01 06:10:29 EDT --- (In reply to comment #1) > I'm not qualified to do a review but here are some informal comments: > > 1: The Source0 URL got me a 404, but I found a link to > http://archive.xfce.org/src/panel-plugins/xfce4-stopwatch-plugin/0.2/xfce4-stopwatch-plugin-0.2.0.tar.bz2 > on the website. The difference is ".x". Has the URL changed? Yes, this was a bug in the goodies release manager webapp, that Jannis fixed after I rolled this package. > 2: desktop-file-install or desktop-file-validate must be used. > (https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage) > Do you have a very good reason not to do this? Yes. All the xfce4-panel plugins have Type=X-XFCE-PanelPlugin instead of Type=Application Although this is a valid extension of the freedesktop.org specs, desktop-file-utils refuse to install or verify the files. > 3: RPMlint says: > xfce4-stopwatch-plugin.x86_64: W: incoherent-version-in-changelog 0.7.2-1 > ['0.2.0-1.fc11', '0.2.0-1'] > The spec in the source RPM has the wrong version number in the changelog. In > the separate spec it's correct. > > 4: It's not exactly a serious problem but there's a typo in the changelog. It > says "Fedpra". Thanks for catching these. Updated files: http://cwickert.fedorapeople.org/review/xfce4-stopwatch-plugin.spec http://cwickert.fedorapeople.org/review/xfce4-stopwatch-plugin-0.2.0-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review