Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=514351 Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn@xxxxxxxxxxxxxxxxxxxx --- Comment #1 from Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> 2009-08-01 04:29:51 EDT --- I'm not qualified to do a review but here are some informal comments: 1: The Source0 URL got me a 404, but I found a link to http://archive.xfce.org/src/panel-plugins/xfce4-stopwatch-plugin/0.2/xfce4-stopwatch-plugin-0.2.0.tar.bz2 on the website. The difference is ".x". Has the URL changed? 2: desktop-file-install or desktop-file-validate must be used. (https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage) Do you have a very good reason not to do this? 3: RPMlint says: xfce4-stopwatch-plugin.x86_64: W: incoherent-version-in-changelog 0.7.2-1 ['0.2.0-1.fc11', '0.2.0-1'] The spec in the source RPM has the wrong version number in the changelog. In the separate spec it's correct. 4: It's not exactly a serious problem but there's a typo in the changelog. It says "Fedpra". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review