Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513896 --- Comment #4 from Mark Goodwin <mgoodwin@xxxxxxxxxx> 2009-07-31 02:47:49 EDT --- Following lengthy review discussions with Eric Sandeen (thanks Eric) and several PCP community developers, and after working thru errors and warnings reported by 'rpmlint', the changes listed below have been committed to the 'dev' branch in my tree at git://oss.sgi.com/markgw/pcp/pcp.git For review purposes, the Fedora specific spec and SRPM for PCP have been copied up to : Spec URL: ftp://oss.sgi.com/projects/pcp/download/v3/pcp.spec SRPM URL: ftp://oss.sgi.com/projects/pcp/download/v3/pcp-3.0.0-1.fc10.src.rpm Most of the changes made so far are to the Fedora RPM spec itself - these need to be reconciled, where possible, with the community RPM spec. The remaining changes are mostly to silence rpmlint: * pcp-libs.x86_64: E: library-without-ldconfig-postin To fix, need to add a "%post libs" scriptlet to call to ldconfig * pcp-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libpcp_pmda.so.3 Nothing can really be done about this - the exit() context is well known and understood. * pcp.x86_64: E: arch-dependent-file-in-usr-share Several demo binaries are being installed in /usr/share/pcp/demo. I can move these elsewhere, if requested. These binaries are not used by the PCP core functionality. * pcp.x86_64: W: devel-file-in-non-devel-package Several headers and some 'C' files in PCP are actually configuration files. Discussed with the PCP community and they agree to leave these as-is. * pcp.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/pcp Well, it actually isn't a config file - we want it unconditionally updated after an upgrade. Same for /etc/pcp.env * pcp.x86_64: W: log-files-without-logrotate /var/log/pcp PCP has it's own log management system, see pmlogger_daily(1) * pcp.x86_64: W: dangerous-command-in-%post chmod * pcp.x86_64: W: dangerous-command-in-%preun rm This could be avoided with %ghost directive, if needed. * pcp.x86_64: E: subsys-not-used /etc/rc.d/init.d/pmproxy * pcp.x86_64: E: subsys-not-used /etc/rc.d/init.d/pmie * pcp.x86_64: E: subsys-not-used /etc/rc.d/init.d/pcp rpmlint suggests we need to set up a lock file in /var/lock/subsys. Changes commited so far to git://oss.sgi.com/markgw/pcp/pcp.git (most recent changes are listed first). Please clone my git tree if you want to see the patches : commit 5dc76a384254b3a0b1a72ff1be5faec042effa73 Author: Mark Goodwin <mgoodwin@xxxxxxxxxx> Date: Fri Jul 31 15:44:40 2009 +1000 RPM spec specifically for the Fedora Project. Signed-off-by: Mark Goodwin <mgoodwin@xxxxxxxxxx> commit 1274605472853400f4297439c433a05829735a64 Author: Mark Goodwin <mgoodwin@xxxxxxxxxx> Date: Fri Jul 31 15:40:58 2009 +1000 tweak configure to move PCP_BINADM_DIR out of /usr/share, into /usr/lib. Arch dependent binaries should not be installed below /usr/share. Signed-off-by: Mark Goodwin <mgoodwin@xxxxxxxxxx> commit 17700e2bdaa0060178c3d025edb92280f36451f6 Author: Mark Goodwin <mgoodwin@xxxxxxxxxx> Date: Fri Jul 31 11:47:39 2009 +1000 delete unneeded explicit script interpreter to keep rpmlint happy Signed-off-by: Mark Goodwin <mgoodwin@xxxxxxxxxx> commit b971772c281a5aff6408981e7086cbfa4bcee6ba Author: Mark Goodwin <mgoodwin@xxxxxxxxxx> Date: Fri Jul 31 11:33:20 2009 +1000 pmpost does not really need to be setuid Signed-off-by: Mark Goodwin <mgoodwin@xxxxxxxxxx> commit 0a4cd4b8bfe44265bdccfb93db5e19c28c796f79 Author: Mark Goodwin <mgoodwin@xxxxxxxxxx> Date: Fri Jul 31 11:11:48 2009 +1000 Nuke migrate_pcp_var_dir, no longer needed Signed-off-by: Mark Goodwin <mgoodwin@xxxxxxxxxx> commit bf98168e8a7cea7697497f4972dd835fa10e29b6 Author: Mark Goodwin <mgoodwin@xxxxxxxxxx> Date: Thu Jul 30 18:25:12 2009 +1000 default chkconfig off for all PCP services Signed-off-by: Mark Goodwin <mgoodwin@xxxxxxxxxx> commit 3baf8e7a6491c9533a1b0ff00c6d711a32677536 Author: Mark Goodwin <mgoodwin@xxxxxxxxxx> Date: Mon Jul 27 09:32:57 2009 +1000 take -fstack-protector-all back out again since it's only supported with newer compilers. Probably should add a configure test for it at some stage Signed-off-by: Mark Goodwin <mgoodwin@xxxxxxxxxx> commit 0c1b4b2f4bd9b0759964fb056a1469b2dd052ce6 Author: Mark Goodwin <mgoodwin@xxxxxxxxxx> Date: Wed Jul 22 17:02:40 2009 +1000 Tweak RPM dependency rules for 2.x -> 3.x upgrades and massage the PCP RPM spec to reduce rpmlint noise. Also added -fstack-protector-all to Linux PCFLAGS. On branch 3.0.0: modified: build/rpm/pcp.spec.in modified: src/include/builddefs.in Signed-off-by: Mark Goodwin <mgoodwin@xxxxxxxxxx> commit ff6cfff7845a832ab3b0affe19c6ffa33293bc93 Author: Mark Goodwin <mgoodwin@fletch.(none)> Date: Fri Jul 10 14:36:29 2009 +1000 move pcp.conf into libs and check for pcp-devel in PMDAs that ship a Makefile commit 728c61eb0aa0ebe9bf3b4096696adfc5b14abf39 Author: Mark Goodwin <mgoodwin@fletch.(none)> Date: Thu Jul 9 17:33:12 2009 +1000 split RPM packaging into pcp, pcp-libs and pcp-devel, bump version to 3.0.0 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review