Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513896 --- Comment #3 from Eric Sandeen <esandeen@xxxxxxxxxx> 2009-07-27 15:38:28 EDT --- I think a lot of the DIST_ROOT DIST_MANIFEST stuff can be simplified. Also is there any real reason to be using /usr/bin/gmake instead of just calling "make?" %clean -[ ! -z "$DIST_ROOT" ] && rm -rf $DIST_ROOT rm -Rf $RPM_BUILD_ROOT %build -/usr/bin/gmake default_pcp +make default_pcp %install rm -Rf $RPM_BUILD_ROOT -DIST_ROOT=$RPM_BUILD_ROOT -DIST_MANIFEST=`pwd`/install.manifest -export DIST_ROOT DIST_MANIFEST -rm -f $DIST_MANIFEST -/usr/bin/gmake install_pcp +make DIST_ROOT=$RPM_BUILD_ROOT install_pcp -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review