Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511212 Steven Dake <sdake@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sdake@xxxxxxxxxx --- Comment #3 from Steven Dake <sdake@xxxxxxxxxx> 2009-07-22 15:26:58 EDT --- I believe the following needs to change, but I am not an official reviewer. 1) All RPMs created need a LICENSE file added to their respective %doc sections. This will get rid of the annoying rpmlint warning about docs, and also follow the proper guidelines for packaging. 2) libcluster-glue should be called cluster-glue-lib, or cluster-gluelib, or cluster-glue-libs, but not 100% positive on what the exact policy is regarding naming of library packages. A more experienced packager may know or you could ask on the fedora developer ml or in the fedora developer channel on irc. 3) I assume the main cluster-glue package depends on libcluster-glue, but there is no requires for that. (this is the 5 rpmlint bug). I don't believe rpm automatically puts dependencies in subpackages. You have to do that yourself. 4) libcluster-glue-devel should be called cluster-gluelib-devel or whatever you decided from step #2 above. The rest looks good and the 0700 directory permissions make sense. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review