Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513150 --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-07-22 10:12:07 EDT --- (In reply to comment #1) > - Verified the source matches upstream > - The License matches upstream source file headers. > > APPROVED Thanks! > little nitpicking > > - The release starting with 0. is redundant to version 0. , would use just > 1.whatever I'm afraid, I can't do this. There are no such exceptions in Fedora Packaging Guidelines regarding versioning of packages, based on VCS's snapshots. Anyway, it's not a big issue. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages > - cgit on fdo is nice. I would use > Source0: > http://cgit.freedesktop.org/~libv/bios_extract/snapshot/bios_extract-%{git_commit}.tar.bz2 Thanks for the tip! I didn't know about such feature. Fixed. > - Having at least two executables , perhaps s/Tool/Tools/ everywhere. Done. http://peter.fedorapeople.org/bios_extract.spec http://peter.fedorapeople.org/bios_extract-0-0.2.20090713git.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review