Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513150 Yanko Kaneti <yaneti@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yaneti@xxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |yaneti@xxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Yanko Kaneti <yaneti@xxxxxxxxxxx> 2009-07-22 08:02:16 EDT --- - Verified the source matches upstream - The License matches upstream source file headers. APPROVED little nitpicking - The release starting with 0. is redundant to version 0. , would use just 1.whatever - cgit on fdo is nice. I would use Source0: http://cgit.freedesktop.org/~libv/bios_extract/snapshot/bios_extract-%{git_commit}.tar.bz2 - Having at least two executables , perhaps s/Tool/Tools/ everywhere. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review