Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505259 --- Comment #10 from Juha Tuomala <tuju@xxxxxx> 2009-07-21 11:46:35 EDT --- (In reply to comment #9) > You need to be consistent in your use of $RPM_BUILD_ROOT versus %{buildroot}. fixed. > You seen to use a %pyver macro that is not defined anywhere. It doesn't seem > to make much difference, though; maybe 'make install' doesn't > actually care if you pass PYTHONVER at all. fixed. > %global is recommended over %define these days, although I don't think it > matters for the situation where you're using it. fixed. vim doesn't seem to recognize it, someone should file it somewhere. > The C code isn't compiled with the correct set of compiler flags. > Fortunately -g is passed so the debuginfo package comes out correct >, but you should pass %optflags (or $RPM_OPT_FLAGS if you prefer that form). > Unfortunately it looks like this package thinks it knows best and > overrides CFLAGS, so you may have to patch Makefile.common. You mean that line: CFLAGS = -g -Wall -I$(PYTHONINCLUDE) $(DEFINES) should include itself with CFLAGS := $(CFLAGS) -g -Wall -I$(PYTHONINCLUDE) $(DEFINES) > Your manual python dependency is unnecessary; rpm will generate one. fixed. > The package review process needs reviewers! If you haven't done any package > reviews recently, please consider doing one. I look into it. $ rpmlint --verbose /home/tuju/PKGS/SRPMS/python-utmp-0.7-4.fc10.src.rpm python-utmp.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1489773 src: http://tuju.fi/fedora/11/python-utmp-0.7-4.fc10.src.rpm spec: http://tuju.fi/fedora/11/python-utmp.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review