Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505259 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? --- Comment #9 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-07-08 20:56:32 EDT --- Indeed, builds fine for me and rpmlint is silent. You need to be consistent in your use of $RPM_BUILD_ROOT versus %{buildroot}. Either style is fine, but you must pick one. You seen to use a %pyver macro that is not defined anywhere. It doesn't seem to make much difference, though; maybe 'make install' doesn't actually care if you pass PYTHONVER at all. %global is recommended over %define these days, although I don't think it matters for the situation where you're using it. The C code isn't compiled with the correct set of compiler flags. Fortunately -g is passed so the debuginfo package comes out correct, but you should pass %optflags (or $RPM_OPT_FLAGS if you prefer that form). Unfortunately it looks like this package thinks it knows best and overrides CFLAGS, so you may have to patch Makefile.common. Your manual python dependency is unnecessary; rpm will generate one. * source files match upstream. sha256sum: b411e012244a3433b250a0cd63ce50aaf74ab4ddda8c5ef37c3598ee05ff5f2c python-utmp_0.7.tar.gz * package meets naming and versioning guidelines. X specfile does not use macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible (according to FE-Legal review). * license text included in package. * latest version is being packaged. * BuildRequires are proper. X compiler flags are not correct. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. ? final provides and requires (unnecessary manual python dependency): utmpaccessmodule.so()(64bit) python-utmp = 0.7-3.fc12 python-utmp(x86-64) = 0.7-3.fc12 = ? python python(abi) = 2.6 * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review