Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510734 --- Comment #13 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> 2009-07-20 18:35:42 EDT --- (In reply to comment #8) > - lots of rpmlint errors: > * README/AUTHORS not UTF-8, please convert them in the %prep section via iconv > (please make sure to preserve the timestamp, e.g. by using "touch -c -r > old_file" > * wrong permissions of some of the *.c files, please change the permission to > 644 in the %prep section Excuse me - I don't understand you. *.c files it is sources and they only built and do not go in any packages. Why I shoud care about its permissions? And what mean "wrong" in this context? BTW rpmlint offcourse silent about it. > - the indentation seems to be broken - just open the file with vim or gedit No. Just I use tabsize = 5 spaces. > - please delete the commented Packager: and Vendor: tags, it should be > sufficient to add to your first changelog entry that this spec file is based on > a version from Dag Wieers <dag@...> > > - delete the old non-Fedora changelog entries Ok, I slightly modify it - add historical packagers in changelog, and clear it. > - correct the Source: line > * use Source0 for the primary source file Renamed. Is there any difference in it? I remember it may have sense in patches... in sources too? > * for sf.net please use something like this: > http://downloads.sourceforge.net/libvncserver/%{name}-%{version}.tar.gz > * see also http://fedoraproject.org/wiki/Packaging:SourceURL for details > * verify via "spectool -g x11vnc.spec" whether the sources can be downloaded > using the provided URL Sorry, it is historical URL, some time ago it was correct as i remember. Fixed. > - does not build in rawhide: > https://koji.fedoraproject.org/koji/taskinfo?taskID=1484978 - probably a > missing build requirement since X11/extensions/XInput.h can't be found Oops. I was built it only on Fedora 11, my mistake. Add BR: /usr/include/X11/extensions/XInput.h; In F12 it is located in libXi-devel but in previous versions in xorg-x11-proto-devel so, to do not make conditional requires, require explicit file. Now it built successful: http://koji.fedoraproject.org/koji/taskinfo?taskID=1487807 > - check for spelling mistakes in the comments ;-) ("pathc") I'm try, seriously. My English skills is very low. So do not hesitate point me on such errors too. > > - the source as well as the built package contain some java clients: > * only the server components are mentioned in the %description > * if the clients should be shipped, then put them into separate sub-package > * it is not allowed to use the pre-built JARs > * preferably the pre-built JARs should not even be shipped in the sources (see > http://fedoraproject.org/wiki/Packaging:Java for details) Off course! Such binaries removed in %install stage. > - "Requires: minilzo" is wrong, since there is no package "minilzo". Since > x11vnc is linked against libminilzo.so.0, the dependency should be > automatically added to the binary rpm: > rpm --requires -qp ~rpmbuild/RPMS/i386/x11vnc-0.9.8-3.fc10.i386.rpm |grep lzo > libminilzo.so.0 Fixed. > - would it be an option to use the system's libvncserver library instead of the > internal one? (--use-system-libvncserver This is very interesting question. I think it is will be "right" solution. Additionally it completely solve minilzo problem as I can understand. I try use it now (add --with-system-libvncserver). Add BR libvncserver-devel But I have errors ( http://koji.fedoraproject.org/koji/getfile?taskID=1487784&name=build.log ) several "undefined reference" like: /builddir/build/BUILD/x11vnc-0.9.8/x11vnc/connections.c:3161: undefined reference to `rfbUnregisterTightVNCFileTransferExtension' x11vnc-connections.o: In function `client_gone': /builddir/build/BUILD/x11vnc-0.9.8/x11vnc/connections.c:726: undefined reference to `rfbRegisterTightVNCFileTransferExtension' x11vnc-help.o:make[3]: Leaving directory `/builddir/build/BUILD/x11vnc-0.9.8/x11vnc' In function `print_help': /builddir/build/BUILD/x11vnc-0.9.8/x11vnc/help.c:4862: undefined reference to `rfbRegisterTightVNCFileTransferExtension' Disable this option now, but continue investigation there... > > - when you upload a new version, please also provide also a link to the spec > file - this makes it easier to just have a quick look at it I'm each time upload new spec-file with new src.rpm one. But as it is not versioned (have not version in name) I just omit it link each time, because it is present in initial report. Sorry for confusion. http://hubbitus.net.ru/rpm/Fedora11/x11vnc/x11vnc-0.9.8-4.fc11.src.rpm http://hubbitus.net.ru/rpm/Fedora11/x11vnc/x11vnc.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review