Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508126 Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn@xxxxxxxxxxxxxxxxxxxx --- Comment #2 from Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> 2009-07-19 19:24:43 EDT --- I'm not qualified to do a review but here are some informal comments: RPMlint says: education-bookmarks.src: W: strange-permission default-bookmarks.html 0600 This doesn't seem to hurt. education-bookmarks.src: E: invalid-spec-name The spec file in the source package is called "edu-spin-bookmarks.spec". It should be "education-bookmarks.spec". education-bookmarks.src:13: W: unversioned-explicit-provides system-bookmarks This looks perfectly fine to me. education-bookmarks.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 2) Please replace the tabs with spaces. They serve no purpose and can make the file look ugly in other people's editors. education-bookmarks.noarch: W: no-documentation Well, this package doesn't seem to need much documentation. Source0 should be a complete URL. If this isn't possible, there should be a comment explaining why. The files section contains: %dir %{_datadir}/bookmarks %{_datadir}/bookmarks/default-bookmarks.html Isn't it easier to write just "%{_datadir}/bookmarks" and get the contents of the directory automatically? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review