Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508483 --- Comment #2 from John Guthrie <guthrie@xxxxxxxxxxxxxxxxxx> 2009-07-03 23:40:29 EDT --- (In reply to comment #1) > Hi John, > > I was going to do a full review, however I've stumbled upon some major issues. > Please can you solve them first before I do the complete review? > > - the package contains a rather old snaphost from 1/2008 - can you package a > newer snapshot e.g. from 6/2009? Not done yet. Should be finished in a couple of days. > - rpmlint reveals 139 warnings and errors, especially: Doh! I think I must have run rpmlint on the specfile and then absent-mindedly forgotten to check the RPM that I had just built. Here is the latest output from rpmlint: ewl.i586: W: shared-lib-calls-exit /usr/lib/libewl.so.1.0.0 exit@xxxxxxxxx 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ewl-devel.i586: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. > * formatting fo the description Fixed > * lots of example *.c files in the main package (they should be in the devel > package) Fixed. > * static libraries were packaged - usually they should be completely omitted > unless there is a reason: > http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries Fixed. > * if the %post/%postun section only contains one line, it should be written > like this: > %post -p /sbin/ldconfig Fixed. > - using %ghost for *.so.x should not be necessary, > %{_libdir}/*.so.* should be sufficient Is this true even when the file is a symlink created by the %post section. My thinking was that the *.so.1 files were created by the %post section, so they should be ghosted. > - pkgconfig must be required by the devel pacakge since *.pc is packaged One of the automatically generated requires for the devel package is /usr/bin/pkg-config. Is that not sufficient? > - probably the tests should be moved into the devel package, too > > > Best regards, > Christian I haven't posted the latest package. I'll be posting it once I get a new version of the software. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review