Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508483 --- Comment #1 from Christian Krause <chkr@xxxxxxxxxxx> 2009-07-03 05:23:49 EDT --- Hi John, I was going to do a full review, however I've stumbled upon some major issues. Please can you solve them first before I do the complete review? - the package contains a rather old snaphost from 1/2008 - can you package a newer snapshot e.g. from 6/2009? - rpmlint reveals 139 warnings and errors, especially: * formatting fo the description * lots of example *.c files in the main package (they should be in the devel package) * static libraries were packaged - usually they should be completely omitted unless there is a reason: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries * if the %post/%postun section only contains one line, it should be written like this: %post -p /sbin/ldconfig - using %ghost for *.so.x should not be necessary, %{_libdir}/*.so.* should be sufficient - pkgconfig must be required by the devel pacakge since *.pc is packaged - probably the tests should be moved into the devel package, too Best regards, Christian -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review