Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492203 --- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> 2009-06-30 15:30:22 EDT --- (In reply to comment #5) > Actually the revision number is provided: > I issue "svnversion" between "svn checkout" and "delete .svn directories" to > get the svn revision number. How can I do this with "svn export"? No. To check source I run: $ sh frinika-snapshot.sh and got frinika-548.tar.bz2 tarball opposite your frinika-521.tar.bz2. So, my suggestion here to take in that script at least one argument - revision number, and checkout exactly provided revithion. Then, in spec file comment near this source you write instruction like: # ./frinika-snapshot.sh 521 or, on you choice: # ./%{name}-snapshot.sh %{svnver} Example how I think about it (both revision number as parameter, and "svn export" here) - http://hubbitus.fedorapeople.org/frinika-snapshot.sh Hope if it help. And off course I do not insist on exactly that implementation. > > Also other sources must have comment where it placed. Please refer to > > https://fedoraproject.org/wiki/Packaging/SourceURL#Referencing_Source whan > > link is not accesable. > Other sources? I didn't get your point. %{name}.sh, %{name}.desktop, > %{name}-snapshot.sh are all written by me. Excelent! And add this two words into comment. > > [-] MUST: All build dependencies must be listed in BuildRequires > > BuildRequires: ant > > missing. You provide ant into build-jar-repository, so, its needed. > Strange that I missed this. See buld log: http://koji.fedoraproject.org/koji/getfile?taskID=1444151&name=build.log Straight sfter invoke: $ build-jar-repository -s -p lib toot2 jmod jVorbisEnc jgoodies-looks jakarta-commons-logging skinlf SevenZip next command from it is: $ ant jar javadocs > > This dependencies is only in rawhide? > They are also submitted to stable. They will arrive there in a few days. Good. I think I can test it shorly. (I test it on work notebook, and afraid use rawhide here. Sorry.) > > [-] Patches. Each included patch must have link to upstream bagtracker or > > comment why it can't be done. > > https://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus > The patches are all strictly Fedora specific. I'll add a comment. Really all Fedora related? I think frinika-sevenzip.patch fix real bug. Why you do not wish fill it upstream? > > Should: > > [=] I think in command: > > ln -s %{_libdir}/flexdock/flexdock-0.5.1.jar lib/flexdock.jar || \ > > Will be cool replace "0.5.1" by something like %{version} > That 0.5.1 is flexdock's version, not frinika's. Really. My mistake. But it is also error. You use unversioned BuildRequires: flexdock Requires: flexdock but symlink to exact version of jar. >From this I look again on this symlinks. I think instad of doing such symlink you should use build-classpath: http://fedoraproject.org/wiki/Packaging:Java#build-classpath -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review