Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492203 --- Comment #5 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-06-30 12:51:23 EDT --- (In reply to comment #4) > Here is the review: > Whee! Thanks a lot! > [=] MUST: The package must be licensed with a Fedora approved license and meet > the Licensing Guidelines. > # src/SevenZip is LGPLv2+ or CPL > # The rest is GPLv2+ > License: GPLv2+ and (LGPLv2+ or CPL) > but changelog says what SevenZip now not included. So, I think license shoild > be GPLv2+ now only. Ouch, I forgot to update the license tag after I packaged SevenZip separately. > [-] MUST: The License field in the package spec file must match the actual > license. > Package include dreamfabric Dknob component > http://www.dreamfabric.com/java/knob/knob.html this is not mention any license > in sourse. License text also not included. Did you contact with author and ask > license? > > Also petersalomonsen component included. License there same GPLv2+, but it is > not acceptable bundle any (source or compiled JARs) components in package: > https://fedoraproject.org/wiki/Packaging:Java#Pre-built_JAR_files_.2F_Other_bundled_software > > all such components must be separate packaged and reviewed. > It looks like I missed these ones. I'll do them next. > [-] MUST: The sources used to build the package must match the upstream > source, as provided in the spec URL. > > No. > Package contains script to fetch source from SVN (frinika-snapshot.sh), but it > revision number not provided. And you should add comment how you get source. > In you case it may be simple note about proper usage of frinika-snapshot.sh. > It must be command to copy/paste reproduce. > https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control > > One hint, instead of do "svn checkout" ("svn co") and then delete .svn > directory, you may do just "svn export" > Actually the revision number is provided: I issue "svnversion" between "svn checkout" and "delete .svn directories" to get the svn revision number. How can I do this with "svn export"? > Also other sources must have comment where it placed. Please refer to > https://fedoraproject.org/wiki/Packaging/SourceURL#Referencing_Source whan > link is not accesable. > Other sources? I didn't get your point. %{name}.sh, %{name}.desktop, %{name}-snapshot.sh are all written by me. > [-] MUST: All build dependencies must be listed in BuildRequires > BuildRequires: ant > missing. You provide ant into build-jar-repository, so, its needed. Strange that I missed this. > [=] SHOULD: The reviewer should test that the package functions as described. > Error: Missing Dependency: SevenZip is needed by package > frinika-0.5.1-3.521svn.fc11.noarch (/frinika-0.5.1-3.521svn.fc11.noarch) > Error: Missing Dependency: tootaudioservers >= 3 is needed by package > frinika-0.5.1-3.521svn.fc11.noarch (/frinika-0.5.1-3.521svn.fc11.noarch) > > This dependencies is only in rawhide? > They are also submitted to stable. They will arrive there in a few days. > [-] Patches. Each included patch must have link to upstream bagtracker or > comment why it can't be done. > https://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus The patches are all strictly Fedora specific. I'll add a comment. > Should: > [=] I think in command: > ln -s %{_libdir}/flexdock/flexdock-0.5.1.jar lib/flexdock.jar || \ > Will be cool replace "0.5.1" by something like %{version} > That 0.5.1 is flexdock's version, not frinika's. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review