Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506168 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-06-24 03:15:20 EDT --- Thank you! (In reply to comment #1) > rubygem-allison-2.0.3-allison-path-symlink.patch 0600 > ==> Fix this - Will fix > This is first time I am reviewing ruby package. > 1)Ruby packaging guidelines suggest > gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} > whereas in SPEC its > gem install --local --install-dir $(pwd)%{gemdir} --force --rdoc -V %{SOURCE0} > ==> Though its same if you like can you use %{buildroot} instead $(pwd) - At this case $(pwd) is %{_builddir}/%{name}-%{version} != %{builddir}. Now I have submitted a proposal to move the directory to expand the Gem file from %buildroot to %_builddir, see: https://fedoraproject.org/wiki/PackagingDrafts/Gem_expand_stage_change Now I am waiting for someone to comment on my draft. > 2) Not sure but see Documentation files getting installed at > /usr/lib/ruby/gems/1.8/gems/allison-2.0.3. Can they go to %doc? > Got confused how following got evaluated for main rpm package > %doc %{geminstdir}/[A-Z]* - This is usual for RubyGem packages. We usually don't move these document files (such as LICENSE or so) to %_defaultdocdir because $ gem contents <gemname> expects there (and Rakefile won't work if it is moved from %geminstdir) New Package CVS Request ======================= Package Name: rubygem-allison Short Description: A modern, pretty RDoc template Owners: mtasaka Branches: F-11 F-10 InitialCC: (nobody) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review