Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506168 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-06-24 03:00:02 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1415422 - rpmlint message for SRPM and for RPM. rubygem-allison.src: W: strange-permission rubygem-allison-2.0.3-allison-path-symlink.patch 0600 ==> Fix this + source files match upstream url da73e1dc3856ec3c0fef09a8f5f390743303ed69 allison-2.0.3.gem + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestions: This is first time I am reviewing ruby package. 1)Ruby packaging guidelines suggest gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} whereas in SPEC its gem install --local --install-dir $(pwd)%{gemdir} --force --rdoc -V %{SOURCE0} ==> Though its same if you like can you use %{buildroot} instead $(pwd) 2) Not sure but see Documentation files getting installed at /usr/lib/ruby/gems/1.8/gems/allison-2.0.3. Can they go to %doc? Got confused how following got evaluated for main rpm package %doc %{geminstdir}/[A-Z]* APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review