Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507501 Jim Radford <radford@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(radford@blackbean | |.org) | --- Comment #2 from Jim Radford <radford@xxxxxxxxxxxxx> 2009-06-23 19:07:15 EDT --- (In reply to comment #1) > 1. The licensing code for OFL, is OFL, not SIL Fixed. > 2. Please do not rename the ttf, it makes cross-distro checks easier when > everyone is using the unmodified upstream filename Ok. Fixed. > 3. I don't think you win a lot by creating the fontconfig file dynamically > instead of putting it as Source1. So I'd advise against it. But I won't block > the review on this It's simpler for me to have a single file, so I'll leave that as is. > 4. Please use a leading capital A in the summary Fixed. > 5. Please correct the documentation end of lines Fixed. > 6. Please correct the documentation encoding Fixed. > Apart from that, the spec seems clean and fine Thanks for the review. Spec URL: http://blackbean.org/review/inkboy-fonts.spec SRPM URL: http://blackbean.org/review/inkboy-fonts-20070624-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review