Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497833 --- Comment #2 from Michael Schwendt <mschwendt@xxxxxxxxx> 2009-06-23 05:10:52 EDT --- > SRPM URL: http://fedorapeople.org/~acme/tuna/tuna-0.8.4.tar.bz2 You're expected to put the src.rpm URL there. > %dir %{_datadir}/tuna/help/kthreads/ > %{_datadir}/tuna/help/kthreads/* Due to the catch-all wildcard '*' these two lines could be replaced with just a single line: %{_datadir}/tuna/help/kthreads/ > %changelog Commonly one only sums up packaging related changes there, i.e. actual changes applied to the spec file, not all internal code changes which should be covered by an included ChangeLog file. In particular, mostly only when one adds patch files to the spec or replaces the source tarball, one gives a summary of what is expected to affect the user, but not full internal log of implementation changes. > %defattr(0755,root,root,0755) It's amazing to see that the widely used %defattr(-,root,root,-) [which defaults to %defattr(0644,root,root,0755)] isn't used in this spec file, but no comment explain why it isn't used. Please run rpmlint on the src.rpm *and* the built rpms. Pre-review your own packages in accordance with the Review Guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review