Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506755 --- Comment #12 from Chess Griffin <chess@xxxxxxxxxxxxxxxx> 2009-06-22 10:56:52 EDT --- (In reply to comment #11) > The package is not using the Fedora optimization flags (available through > %{optflags} or $RPM_OPT_FLAGS). You need to patch the makefile to get these > into use. Keep the -D and -I and the -std switches, remove everything else (as > the -W switches). You don't need to touch the libs. Okay, I have this working here, but want to make sure of something before I post a new spec: I should remove the entire -ifeq (${CC},gcc)/-endif block that contains all the -W switches? I have done that and also patched in $(RPM_OPT_FLAGS) to the makefile and it all builds ok here in mock and I can now see that the Fedora optimization flags are being used. Still, I wanted to make sure of my understanding about the -W flags. > > - Add LDFLAGS="$RPM_OPT_FLAGS" to the end of the make command to use the > optimization flags in the linking process too (if the object files have been > compiled e.g. with -fPIC then linking will fail without it). Done. I tried this before but it failed, but most likely because I had not patched the makefile as you pointed out. :-) Patching the makefile to add in the $(RPM_OPT_FLAGS) works fine now. > > - Instead of > examples/* > I'd ship > examples/ > since this is a bit clearer. Yes, good point. Thanks. > > - Add TODO to %doc. > > Done. > I can sponsor you, if you first show me that you know the guidelines. To do > that you need to read the Packaging and the Review Guidelines and to > demonstrate you understand them by making at least one another submission and > do a couple of informal reviews of other people's packages (you'll be able to > do formal ones once I have sponsored you). Jussi, thank you very much. I will continue to study the Guidelines and demonstrate my understanding in the manner that you suggest. I appreciate the feedback and willingness to sponsor me. Cheers! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review