Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506755 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) | --- Comment #13 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-06-22 11:08:59 EDT --- (In reply to comment #12) > (In reply to comment #11) > > The package is not using the Fedora optimization flags (available through > > %{optflags} or $RPM_OPT_FLAGS). You need to patch the makefile to get these > > into use. Keep the -D and -I and the -std switches, remove everything else (as > > the -W switches). You don't need to touch the libs. > > Okay, I have this working here, but want to make sure of something before I > post a new spec: I should remove the entire -ifeq (${CC},gcc)/-endif block > that contains all the -W switches? I have done that and also patched in > $(RPM_OPT_FLAGS) to the makefile and it all builds ok here in mock and I can > now see that the Fedora optimization flags are being used. Still, I wanted to > make sure of my understanding about the -W flags. Sure, you can do that, since you don't need to take into account other compilers than gcc. The -W switches control warnings that the compiler displays, so they're mostly a cosmetic change. $(RPM_OPT_FLAGS) has a -Wall, though, so it's better to remove anything that might collide with it. btw. you can see what rpm macros do with $ rpm --eval %{optflags} (I don't know if it's possible to do the same thing with $RPM_OPT_FLAGS, but these are just two different styles of writing the same thing as %{buildroot} and $RPM_BUILD_ROOT.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review