Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evolution-brutus Alias: evolution-brutus https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520 ------- Additional Comments From colding@xxxxxxxxx 2006-09-05 04:15 EST ------- > > I've put updated srpm and spec files on the site that addresses all of your #2 > > comments (except for your %makeinstall macro comment, what do you mean by > > that?). > http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 OK, I've fixed that in the spec. > Also why are you building with: --enable-brutus-debug=no ? brutus-debug is an internal configure variable that explicitly appends "-ggdb -O1" to CFLAGS and defines BRUTUS_DEBUG. A lot of debug output is printed to stdout when BRUTUS_DEBUG is defined in the source and the environment has BRUTUS_DEBUG defined to something, e.g. "yes". brutus-debug is therefore disabled during rpm build. "-g -O2" is appended to CFLAGS during rpm build so the debuginfo rpms contain the symbols. This srpm and spec has all the updates: Spec URL: http://www.omesc.com/content/downloads/dist/Fedora%20Core%205/SPECS/evolution-brutus.spec SRPM URL: http://www.omesc.com/content/downloads/dist/Fedora%20Core%205/SRPMS/evolution-brutus-1.1.6-4.src.rpm > Don't forget to update the changelog each time you make changes. Yes, I've missed that. The 1.1.6-4 srpm/spec has updated Changelog entries. Thanks, jules -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review