Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 --- Comment #7 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-06-13 05:28:28 EDT --- (In reply to comment #6) > Some notes: > > * URL, Source0 > - Currently the written URL seems invalid and I could not > any files from the URL written as %SOURCE0 Ugh, they're migrating their web pages to a new wiki. Fixed URL to point to old wiki. When I made the package the FTP site had xdrfile-1.1b.tar.gz which fixed the license issue. I see it has now been renamed to xdrfile-1.1.tar.gz, since the files are binary equal. Which means that the default %setup doesn't work. Must make a bug about this upstream. > * About checking size > ----------------------------------------------------- > [ -s ChangeLog ] && exit 1 # exit if file has non-zero size > ----------------------------------------------------- > - Well I guess it is better that you check the tarball and > "ChangeLog" file by yourself instead of resorting to > such method... Well, currently the file has no content, so I want to be notified automatically if at some stage later on it gains content. > * Timestamp > - It is preferred to keep timestamps on installed files > (for this package especially for header files) by: > ----------------------------------------------------- > make install DESTDIR=%{buildroot} INSTALL="install -p" > ----------------------------------------------------- > This method usually works for Makefiles generated by > recent autotools. Whoops, fixed. http://theory.physics.helsinki.fi/~jzlehtol/rpms/xdrfile.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/xdrfile-1.1-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review