Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 --- Comment #6 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-06-12 12:14:50 EDT --- Some notes: * URL, Source0 - Currently the written URL seems invalid and I could not any files from the URL written as %SOURCE0 * About checking size ----------------------------------------------------- [ -s ChangeLog ] && exit 1 # exit if file has non-zero size ----------------------------------------------------- - Well I guess it is better that you check the tarball and "ChangeLog" file by yourself instead of resorting to such method... * Timestamp - It is preferred to keep timestamps on installed files (for this package especially for header files) by: ----------------------------------------------------- make install DESTDIR=%{buildroot} INSTALL="install -p" ----------------------------------------------------- This method usually works for Makefiles generated by recent autotools. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review