Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226117 --- Comment #8 from Jon Ciesla <limb@xxxxxxxxxxxx> 2009-06-11 11:46:08 EDT --- Better. I still get mailman.src:46: E: hardcoded-library-path in /usr/lib/%{name} A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. mailman.src:131: W: configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir} whenever the script supports it. mailman.src: W: mixed-use-of-spaces-and-tabs (spaces: line 63, tab: line 132) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. On the SRPM. There's a *TON* of rpmlint errors on the RPM, mostly perm and gid issues. Some are not. The only ones that concern me are these: Lots of: mailman.i386: E: file-in-usr-marked-as-conffile /usr/lib/mailman/templates/zh_TW/userpass.txt A file in /usr is marked as being a configuration file. Store your conf files in /etc/ instead. mailman.i386: W: dangerous-command-in-%pre rm mailman.i386: W: dangerous-command-in-%post rm mailman.i386: W: incoherent-subsys /etc/rc.d/init.d/mailman $prog The filename of your lock file in /var/lock/subsys/ is incoherent with your actual init script name. For example, if your script name is httpd, you have to use 'httpd' as the filename in your subsys directory. It is also possible that rpmlint gets this wrong, especially if the init script contains nontrivial shell variables and/or assignments. These cases usually manifest themselves when rpmlint reports that the subsys name starts a with '$'; in these cases a warning instead of an error is reported and you should check the script manually. mailman.i386: W: incoherent-subsys /etc/rc.d/init.d/mailman $prog The filename of your lock file in /var/lock/subsys/ is incoherent with your actual init script name. For example, if your script name is httpd, you have to use 'httpd' as the filename in your subsys directory. It is also possible that rpmlint gets this wrong, especially if the init script contains nontrivial shell variables and/or assignments. These cases usually manifest themselves when rpmlint reports that the subsys name starts a with '$'; in these cases a warning instead of an error is reported and you should check the script manually. mailman.i386: W: service-default-enabled /etc/rc.d/init.d/mailman The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service. All need fixing. Still present from #3. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review