[Bug 226117] Merge Review: mailman

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226117





--- Comment #7 from Daniel Novotny <dnovotny@xxxxxxxxxx>  2009-06-11 09:31:33 EDT ---
hello,
I worked on the .spec file to adress these issues.

see
http://people.fedoraproject.org/~dnovotny/review/mailman.spec

these are my changes:

* hardcoded library path changed to %{_libdir}
* mixed use of spaces and tabs fixed
* added  --libdir=%{_libdir} to configure
* fixed URL to tarball
* permission of source files changed to 0644 (no strange-permission warnings on
.src.rpm)
* got rid of "file listed twice" warnings: listing the files explicitly

the source files permission changes can't be seen in the .spec, I had to do it
in the cvs checkout

as for the permission and setgid warnings, I guess mailman needs them that way. 

Also the incoherent-subsys warnings can be ignored because

"It is also possible that rpmlint gets this wrong, especially if the init
script contains nontrivial shell variables and/or assignments.  These cases
usually manifest themselves when rpmlint reports that the subsys name starts a
with '$'"

which is exactly the case.

Do you think that's all, or do I have to fix something more?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]