Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504430 --- Comment #6 from Joseph Smidt <josephsmidt@xxxxxxxxx> 2009-06-07 20:00:27 EDT --- (In reply to comment #5) > - You have > BuildRequires: healpix-c++-devel > BuildRequires: cfitsio-devel > so > BuildRequires: healpix-c++ > BuildRequires: cfitsio > is redundant (these are pulled in by the -devel packages). > I meant: Requires: healpix-c++ Requires: cfitsio so I believe this is now fixed. > - You are not building in %build. Use > python setup.py build > in %build and > python setup.py install -O1 --skip-build --root %{buildroot} > in %install. Done > > - Without looking at its contents, INSTALL shouldn't probably be in %doc (if > its only contents is instructions for installation from source, then it > shouldn't be included). > Done > - You must in any case own the directory > %{python_sitearch}/%{name}/ > so you can drop the three last lines from the %files section. > Done. I believe I did what you meant. > - Add comment about the patch. Done. > Also, you could remove the internal healpix and > cfitsio libraries from the extracted tarball in the setup phase so that one can > be sure that they are not used instead of the Fedora packages. Done. I have removed the entire directory containing the healpix and cfitsio libraries in the setup phase. The new files are again at: Spec URL: http://jsmidt.fedorapeople.org/healpy.spec SRPM URL: http://jsmidt.fedorapeople.org/healpy-0.9.6-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review