Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504430 --- Comment #5 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-06-07 18:17:25 EDT --- - You have BuildRequires: healpix-c++-devel BuildRequires: cfitsio-devel so BuildRequires: healpix-c++ BuildRequires: cfitsio is redundant (these are pulled in by the -devel packages). - You are not building in %build. Use python setup.py build in %build and python setup.py install -O1 --skip-build --root %{buildroot} in %install. - Without looking at its contents, INSTALL shouldn't probably be in %doc (if its only contents is instructions for installation from source, then it shouldn't be included). - You must in any case own the directory %{python_sitearch}/%{name}/ so you can drop the three last lines from the %files section. - Add comment about the patch. Also, you could remove the internal healpix and cfitsio libraries from the extracted tarball in the setup phase so that one can be sure that they are not used instead of the Fedora packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review