Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gresistor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196120 ------- Additional Comments From cgoorah@xxxxxxxxxxxx 2006-09-04 06:57 EST ------- (In reply to comment #13) > First review of gresistor: > > 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : > > * Licensing > - Well, it seems that this package is distributed under > GPL (my recognition is that GPL is more strict than LGPL, > so if the package includes the code of both GPL and LGPL, > the license of the whole package is GPL, perhaps). > However, it would be better that you ask for upstream to > clarify the license (from the discussion above, it seems > you have already did it). Ok, I've opted for GPL > * Requires: > - python <- required by pygtk2-libglade > Also, this package requires python(abi) = 2.4. Fixed > * Compiler flags > - Well, usually CFLAGS="$RPM_OPT_FLAGS" is needed, however, > how about for this package? This src package don't have any .c > files and this is a NOARCH package, so CFLAGS should not be > necessary. Fixed > 2. From http://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets : > > * Requires(post,postun) > - Well, all of Requires(post,postun) seems unnecessary accoding to > the URL above. (%post, %postun scriptlets are necessary), Fixed > * GTK+ icon cache > - No icons are installed under /usr/share/icons. Perhaps it is > better that > + create symlink under /usr/share/icons/hicolor/48x48/apps which > points to /usr/share/gresistor/icon.png > + fix (fedora-)gresistor.desktop > + and call gtk-update-icon-cache > Actually it already installs its own png at /usr/share/gresistor/icon.png, the use of GTK+ icon cache and touch --no-create %{_datadir}/icons/hicolor was to update gnome/kde menus just after the install of gresistor. Hence a kde/gnome restart is not required to update the icons in the gnome/kde menus. Updated http://chitlesh.funpic.de/rpm/gresistor.spec http://chitlesh.funpic.de/rpm/gresistor-0.0.1-6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review