Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gresistor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196120 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-09-03 09:17 EST ------- First review of gresistor: 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Licensing - Well, it seems that this package is distributed under GPL (my recognition is that GPL is more strict than LGPL, so if the package includes the code of both GPL and LGPL, the license of the whole package is GPL, perhaps). However, it would be better that you ask for upstream to clarify the license (from the discussion above, it seems you have already did it). * Requires: - python <- required by pygtk2-libglade Also, this package requires python(abi) = 2.4. * Compiler flags - Well, usually CFLAGS="$RPM_OPT_FLAGS" is needed, however, how about for this package? This src package don't have any .c files and this is a NOARCH package, so CFLAGS should not be necessary. 2. From http://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets : * Requires(post,postun) - Well, all of Requires(post,postun) seems unnecessary accoding to the URL above. (%post, %postun scriptlets are necessary), * GTK+ icon cache - No icons are installed under /usr/share/icons. Perhaps it is better that + create symlink under /usr/share/icons/hicolor/48x48/apps which points to /usr/share/gresistor/icon.png + fix (fedora-)gresistor.desktop + and call gtk-update-icon-cache 3. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing. 4. Other things I have noticed: = Nothing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review