Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503967 --- Comment #2 from Dan Williams <dcbw@xxxxxxxxxx> 2009-06-03 15:30:31 EDT --- (In reply to comment #1) > Version: 20090602 > > Will this always be versioned by the date? Perhaps "0.20090602" might be > better to allow for real version numbers in the future without Epoch? Done. > BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) > > This isn't even used by modern rpmbuild. Doesn't need to be so complicated. Recommended by packaging guidelines. > ExclusiveArch: noarch > > Please use "BuildArch: noarch" instead, except the next problem... Done. > [warren@newcaprica noarch]$ rpmlint > mobile-broadband-provider-info-20090602-1.fc11.noarch.rpm > mobile-broadband-provider-info.noarch: W: devel-file-in-non-devel-package > /usr/lib64/pkgconfig/mobile-broadband-provider-info.pc > > This is a serious problem. Note the lib64 dir. Perhaps you can't make this > noarch if you want to use pkgconfig? Removed. > [warren@newcaprica SRPMS]$ rpmlint > mobile-broadband-provider-info-20090602-1.fc11.src.rpm > mobile-broadband-provider-info.src:25: W: make-check-outside-check-section make > check Fixed. > mobile-broadband-provider-info.src:38: W: libdir-macro-in-noarch-package (main > package) %attr(0644,root,root) %{_libdir}/pkgconfig/%{name}.pc removed. Spec URL: http://bigw.org/~dan/mobile-broadband-provider-info.spec SRPM URL: http://bigw.org/~dan/mobile-broadband-provider-info-0.20090602-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review