Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evolution-brutus Alias: evolution-brutus https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520 sander@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sander@xxxxxxxxxxx ------- Additional Comments From sander@xxxxxxxxxxx 2006-09-03 08:32 EST ------- at first glance: - change make to: make %{?_smp_mflags} - pkgconfig is not really needed as a buildrequire, since it is also required by gnome-common. - Vendor and Packager tag should be removed - I guess the autoreq tag can go as well - replace license with just the text GPL - --enable-brutus-debug=no should be yes to build with symbols? - don't use the macro %makeinstall since it is broken - BuildRequires: gettext is missing (required to build the translations) I am not a sponsor so I can't approve your package, but I hope my directions help. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review