Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501098 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-05-18 00:33:25 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1357637 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a44ad501b84d1fd31c4d77e80fdd927f67ebc5aa XML-RSS-LibXML-0.3004.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=34, Tests=701, 8 wallclock secs ( 0.06 usr 0.05 sys + 7.53 cusr 0.62 csys = 8.26 CPU) + Package perl-XML-RSS-LibXML-0.3004-1.fc12.noarch => Provides: perl(XML::RSS::LibXML) = 0.3004 perl(XML::RSS::LibXML::ImplBase) perl(XML::RSS::LibXML::MagicElement) = 0.02 perl(XML::RSS::LibXML::Namespaces) perl(XML::RSS::LibXML::Null) perl(XML::RSS::LibXML::V0_9) perl(XML::RSS::LibXML::V0_91) perl(XML::RSS::LibXML::V1_0) perl(XML::RSS::LibXML::V2_0) Requires: perl(Carp) perl(DateTime::Format::Mail) perl(DateTime::Format::W3CDTF) perl(UNIVERSAL::require) perl(XML::LibXML) perl(XML::LibXML::XPathContext) perl(XML::RSS::LibXML::MagicElement) perl(XML::RSS::LibXML::Namespaces) perl(base) perl(overload) perl(strict) perl(vars) perl(warnings) + Not a GUI application APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review