Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501099 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-05-18 00:33:07 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1357657 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 04d0c175f9bbabc8ba8373d2d6b6ed338bacaab2 XML-Feed-0.43.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=21, Tests=378, 7 wallclock secs ( 0.10 usr 0.04 sys + 6.04 cusr 0.63 csys = 6.81 CPU) + Packageperl-XML-Feed-0.43-1.fc12.noarch => Provides: perl(XML::Feed) = 0.43 perl(XML::Feed::Content) perl(XML::Feed::Enclosure) perl(XML::Feed::Entry) perl(XML::Feed::Entry::Format::Atom) perl(XML::Feed::Entry::Format::RSS) perl(XML::Feed::Format::Atom) perl(XML::Feed::Format::RSS) Requires: perl(Carp) perl(DateTime::Format::Mail) perl(DateTime::Format::W3CDTF) perl(Feed::Find) perl(LWP::UserAgent) perl(List::Util) perl(Module::Pluggable) perl(Scalar::Util) perl(URI::Fetch) perl(XML::Atom::Content) perl(XML::Atom::Entry) perl(XML::Atom::Feed) perl(XML::Atom::Util) perl(XML::Feed::Content) perl(base) perl(strict) + Not a GUI application APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review