Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500437 --- Comment #3 from Kevin Fenzi <kevin@xxxxxxxxx> 2009-05-12 14:48:11 EDT --- Thats for the review! >Bad: >- Please replace: > > >%build >make PREFIX=/usr > >%install >rm -rf $RPM_BUILD_ROOT >make install DESTDIR=$RPM_BUILD_ROOT PREFIX=/usr sysconfdir=/etc > >by: > >%build >make PREFIX=%{_prefix} > >%install >rm -rf $RPM_BUILD_ROOT >make install DESTDIR=$RPM_BUILD_ROOT PREFIX=%{_prefix} >sysconfdir=%{_sysconfdir} Done. >- No smp enabled build The build step is a single sed call. I will add smp if you insist, but it really makes no sense at all. >- Please replace > >%{_sysconfdir}/dbus-1/system.d/cnetworkmanager.conf >%{_sysconfdir}/dbus-1/system.d/cnetworkmanager-06.conf > >%config(noreplace) %{_sysconfdir}/dbus-1/system.d/cnetworkmanager.conf >%config(noreplace) %{_sysconfdir}/dbus-1/system.d/cnetworkmanager-06.conf I don't think these are supposed to be config files. See gdm, NetworkManager, ConsoleKit, etc. None of them mark them as config. Users should not be editing these. It's just a bug that they are under /etc/ I guess. >- Package contains a source file with has a public domain copyright note > in the header. License tag should be 'GPLv2+ and Public Domain' Ah, good point. Fixed. > >- Rpmlint has warning on binary rpm: > >rpmlint cnetworkmanager-0.8.4-1.fc10.noarch.rpm >cnetworkmanager.noarch: W: non-conffile-in-etc >/etc/dbus-1/system.d/cnetworkmanager.conf >cnetworkmanager.noarch: W: non-conffile-in-etc >/etc/dbus-1/system.d/cnetworkmanager-06.conf Which I think can be ignored. >- Package python-gobject2 doesn't exist in Fedora. > >If you want to introduced this missing package in Fedora, please set a blocker >bug to this review. Oops. That should be pygobject2. Fixed. Spec URL: http://www.scrye.com/~kevin/fedora/cnetworkmanager/cnetworkmanager.spec SRPM URL: http://www.scrye.com/~kevin/fedora/cnetworkmanager/cnetworkmanager-0.8.4-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review