Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500437 Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jochen@xxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jochen@xxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-05-12 14:05:42 EDT --- Good: + Basename of SPEC files matches with package name + Package name fullfill naming guildelines + Package contains no subpackages + Package contains valid license tag + License tag has GPLv2+ as an valid OSS license + Package contains verbain copy of the license text + URL tag contains URL of project home page + Could download source tar ball from upstream with spectool -g + Tar ball matches with upstream source (md5sum: 8f3eccaeff900cd68e19785f13c813ab) + Local build works fine + Koji scratch build works fine + Rpmlint is quite on source rpm + %doc stanza is small, so we need no extra subpackage + Files has proper file permissions + %files stanza doesn't contains duplicate entries + All package files are owned by this package + No packaged files belong to another package + Package contains proper %Changelog Bad: - Please replace: %build make PREFIX=/usr %install rm -rf $RPM_BUILD_ROOT make install DESTDIR=$RPM_BUILD_ROOT PREFIX=/usr sysconfdir=/etc by: %build make PREFIX=%{_prefix} %install rm -rf $RPM_BUILD_ROOT make install DESTDIR=$RPM_BUILD_ROOT PREFIX=%{_prefix} sysconfdir=%{_sysconfdir} - No smp enabled build - Please replace %{_sysconfdir}/dbus-1/system.d/cnetworkmanager.conf %{_sysconfdir}/dbus-1/system.d/cnetworkmanager-06.conf %config(noreplace) %{_sysconfdir}/dbus-1/system.d/cnetworkmanager.conf %config(noreplace) %{_sysconfdir}/dbus-1/system.d/cnetworkmanager-06.conf - Package contains a source file with has a public domain copyright note in the header. License tag should be 'GPLv2+ and Public Domain' - Rpmlint has warning on binary rpm: rpmlint cnetworkmanager-0.8.4-1.fc10.noarch.rpm cnetworkmanager.noarch: W: non-conffile-in-etc /etc/dbus-1/system.d/cnetworkmanager.conf cnetworkmanager.noarch: W: non-conffile-in-etc /etc/dbus-1/system.d/cnetworkmanager-06.conf - Package python-gobject2 doesn't exist in Fedora. If you want to introduced this missing package in Fedora, please set a blocker bug to this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review