Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498413 --- Comment #8 from Thomas Sailer <t.sailer@xxxxxxxxxxxxxx> 2009-05-10 13:08:33 EDT --- (In reply to comment #7) > But this is up to you. At least for desktop-file-validate I'd use wildcards > because you might forget to validate a file otherwise. desktop-file-validate does not support multiple desktop files on its command line, so it needs to be enclosed in a for loop. > Encoding should not be in the file, this is correct, but the rest of the file Why should it not be? We seem to have lots of desktop files having an Encoding entry (lots of gnome-*, eg.). > But there are other problems with the desktop files: > - /usr/bin is hardcoded in the Exec tag. Ether remove it or walk over it with Removed the hardcoded path. > - What is "X-Osso-Type=application/x-executable" meant for? Are these programs > supposed to open a mimetype? I guess not, at least not x-executable, but if so, > you need to follow This is needed for maemo. On Fedora, it can go, so removed the X- tags. SRPM: http://sailer.fedorapeople.org/vfrnav-0.3-5.fc11.src.rpm SPEC: http://sailer.fedorapeople.org/vfrnav.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review