Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498413 Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxxxxx Bug 498413 depends on bug 438588, which changed state. Bug 438588 Summary: Review Request: zfstream - C++ iostream like access to compressed files https://bugzilla.redhat.com/show_bug.cgi?id=438588 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE --- Comment #7 from Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> 2009-05-08 15:17:53 EDT --- (In reply to comment #4) > Like this: > %dir %{_datadir}/%{name} > %{_datadir}/%{name}/* And even shorter to %{_datadir}/%{name}/ (In reply to comment #5) > Yes I know I can use wildcards, however I'd like to get notified (by the > unpackaged files check) if something changes there, so I would like to keep tne > enumeration of all files in that directory. Well, IMO you just need to make sure you don't accidentally package unwanted files like leftovers from svn or cvs. I would use %dir %{_datadir}/%{name} %{_datadir}/%{name}/*.png %{_datadir}/%{name}/*.svg %{_datadir}/%{name}/*.glade But this is up to you. At least for desktop-file-validate I'd use wildcards because you might forget to validate a file otherwise. (In reply to comment #6) > Take a look at other desktop files. None of them has Encoding, Version, > X-WIndow-Icon, X-Osso-Type. Encoding should not be in the file, this is correct, but the rest of the file is acceptable. The version key is usually added during install by desktop-file-install and the other keys starting with X- are ok. Whenever you want to extend the freedesktop spec with custom keys you need to prefix them with X-, see http://standards.freedesktop.org/menu-spec/latest/ and especially http://standards.freedesktop.org/menu-spec/latest/ar01s03.html But there are other problems with the desktop files: - /usr/bin is hardcoded in the Exec tag. Ether remove it or walk over it with sed during %prep to make sure the path always works: sed -i 's!/usr/bin!%{_bindir}!' data/*.desktop - What is "X-Osso-Type=application/x-executable" meant for? Are these programs supposed to open a mimetype? I guess not, at least not x-executable, but if so, you need to follow https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review