Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497572 --- Comment #6 from Simon Wesp <cassmodiah@xxxxxxxxxxxxxxxxx> 2009-05-10 10:33:43 EDT --- > - Add executable flags to the non-executable-script files, that way at the end > you only get 3 devel-file-in-non-devel-package warnings that cannot be > circumvented. > - Package does not install. This is caused by > peppy/editra/tests/octave.oct:#! /bin/octave -qf > in which /bin/octave should be /usr/bin/octave. The requirement on octave is, > however, quite odd. The package also requires csh and ksh due to the example > files. I'd sed the shebangs out of those files, since at least octave pulls in > a lot of stuff. removing shebangs of all files should do the trick to clear both. -- build.log -- + sed -e 1d -i peppy/editra/tests/c-shell_script.csh peppy/editra/tests/octave.oct peppy/editra/tests/perl.pl peppy/editra/tests/ruby.rb peppy/editra/tests/d.d peppy/editra/tests/tcl_tk.tcl peppy/editra/tests/korn_shell_script.ksh peppy/editra/tests/python.python > - Add -O1 to the setup.py install arguments. -- build.log -- + python setup.py install -01 --skip-build --root /builddir/build/BUILDROOT/peppy-0.9.27-1.fc11.i386 /usr/lib/python2.6/distutils/dist.py:266: UserWarning: Unknown distribution option: 'zip_safe' warnings.warn(msg) /usr/lib/python2.6/distutils/dist.py:266: UserWarning: Unknown distribution option: 'windows' warnings.warn(msg) packages = ['peppy', 'peppy.yapsy', 'peppy.editra', 'peppy.editra.eclib', 'peppy.editra.syntax', 'peppy.i18n', 'peppy.lib', 'peppy.plugins', 'peppy.vfs', 'peppy.vfs.itools', 'peppy.vfs.itools.uri', 'peppy.vfs.itools.vfs', 'peppy.actions', 'peppy.hsi'] usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] or: setup.py --help [cmd1 cmd2 ...] or: setup.py --help-commands or: setup.py cmd --help error: option -0 not recognized > - The line > mkdir -p %{buildroot}/%{_datadir}/{applications,pixmaps} > is not needed since both desktop-file-install and install -D create the > directories. -- build.log -- + desktop-file-install --dir=/builddir/build/BUILDROOT/peppy-0.9.27-1.fc11.i386//usr/share/applications/ /builddir/build/SOURCES/peppy.desktop + install -Dpm0644 /builddir/build/SOURCES/peppy.png /builddir/build/BUILDROOT/peppy-0.9.27-1.fc11.i386//usr/share/pixmaps/ install: target `/builddir/build/BUILDROOT/peppy-0.9.27-1.fc11.i386//usr/share/pixmaps/' is not a directory: No such file or directory > MUST: The spec file for the package is legible and macros are used > consistently. NEEDSFIX > - You are mixing $RPM_BUILD_ROOT and %{buildroot}. This is not allowed: choose > one and stick with it. oops > MUST: All relevant items are included in %doc. Items in %doc do not affect > runtime of application. NEEDSFIX > - Add also PKG-INFO to %doc. k > - Don't refer to "I" or "me" in the %description. I removed this part completely > - Add Requires: python-enchant to get the spell checking part working. spell checking is a damn bitch. I hate it. But okay, for the most users this is an important "feature". Spec URL: http://cassmodiah.fedorapeople.org/peppy-0.9.27/peppy.spec SRPM URL: http://cassmodiah.fedorapeople.org/peppy-0.9.27/peppy-0.9.27-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review