Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499319 --- Comment #6 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-05-09 06:37:06 EDT --- (In reply to comment #5) > - Why do you disable threading? Duh, you explaiend it in comment #1. - You are not providing snmptools, http://fedoraproject.org/wiki/Packaging/Tcl#Naming_Conventions . This is OK, considering the genericish base name of the package. - Doesn't the version macro at http://fedoraproject.org/wiki/Packaging/Tcl#arch-specific_packages work? Where does it fail? - Have you tried the configure argument --libdir=%{tcl_sitearch} to change the default install location? - Do you really need to specify --with-tcl=%{_libdir}? OK, on multiarch arches with both 32- and 64-bit versions installed you might get into trouble if configure picks up the wrong version. No hurt having this if you think it's necessary. rpmlint output: tcl-snmptools.src: W: invalid-license CMU tcl-snmptools.x86_64: W: invalid-license CMU tcl-snmptools-debuginfo.x86_64: W: invalid-license CMU 3 packages and 0 specfiles checked; 0 errors, 3 warnings. - License tag should be MIT (see http://fedoraproject.org/wiki/Licensing ). But this is really not necessary, since CMU is compatible with GPL and License: GPLv3+ is enough. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. NEEDSFIX - See comment above, license tag should be just GPLv3+. MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK UST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. NEEDSFIX - Even though the files that are installed are generated, it's always nice to preserve time stamps in install phase. Use INSTALL="install -p" as argument to make install. MUST: Packages containing shared library files must call ldconfig. N/A MUST: A package must own all directories that it creates or require the package that owns the directory. ~OK - Instead of %dir %{tcl_sitearch}/%{realname}%{version} %{tcl_sitearch}/%{realname}%{version}/*.so %{tcl_sitearch}/%{realname}%{version}/pkgIndex.tcl just put %{tcl_sitearch}/%{realname}%{version}/ as this will own the directory and everything in it. MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. NEEDSFIX - Add AUTHORS. BUGS and TODO should otherwise be included, but now they just contain instructions to grep the code. MUST: Header files must be in a -devel package. N/A MUST: Static libraries must be in a -static package. N/A MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. N/A MUST: Packages does not contain any .la libtool archives. N/A MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review