Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497140 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-05-03 16:43:05 EDT --- Oh, this has been left hanging, sorry. Lukas is right: you are mixing macros which is not allowed. Choose either $RPM_BUILD_ROOT or %{buildroot} and stick with it, don't mix the two. Also, I don't like to see macros used for standard unix commands, but this is maybe more a matter of style. I think it just makes the spec file harder to read. I'll trust you to fix the macro issue upon import to CVS. The package has been APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review