Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497869 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-04-28 00:19:29 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1323070 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a36fcf49cb66435a59978e52050aead4 MooseX-Role-XMLRPC-Client-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=30, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.22 cusr 0.10 csys = 1.36 CPU) + Package perl-MooseX-Role-XMLRPC-Client-0.03-1.fc12.noarch => Provides: perl(MooseX::Role::XMLRPC::Client) = 0.03 Requires: perl(HTTP::Cookies) perl(MooseX::Role::Parameterized) perl(MooseX::Types::Moose) perl(MooseX::Types::Path::Class) perl(MooseX::Types::URI) perl(RPC::XML::Client) perl(namespace::clean) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review