[Bug 492971] Review Request: lv2-zynadd-plugins - LV2 port of the ZynAddSubFX engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492971





--- Comment #2 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx>  2009-04-23 11:27:42 EDT ---
In reply to comment #1)
> Fedora review lv2-zynadd-plugins-1-2.fc10.src.rpm 2009-04-23

Thank you.

> 
> ! rpmlint warning is fixable (replace the space on line 12 with a tab)
> 

Fixed. I couldn't find any spaces in the line. Anyway, I removed all the
whitespace and recreated the tabs, now there's no rpmlint. Weird.

> ? BuildRequires on jack-audio-connection-kit-devel - is it needed?
> 

I don't think so. No idea how it got there. Removed.

> ! Neither the package nor any of its Requires own %{_libdir}/lv2
>   (the other two plugin packages have Requires: lv2core)
> 

My sloppiness. Added requires.
Spec URL: http://oget.fedorapeople.org/review/lv2-zynadd-plugins.spec
SRPM URL:
http://oget.fedorapeople.org/review/lv2-zynadd-plugins-1-3.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]