Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492971 --- Comment #1 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> 2009-04-23 10:10:41 EDT --- Fedora review lv2-zynadd-plugins-1-2.fc10.src.rpm 2009-04-23 * OK ! Needs attention ? Needs clarification rpmlint output: lv2-zynadd-plugins.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 3) lv2-zynadd-plugins.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 3) 3 packages and 1 specfiles checked; 0 errors, 2 warnings. ! rpmlint warning is fixable (replace the space on line 12 with a tab) * Package is named according to guidelines * Specfile is named after the package * The package is licensed as GPLv2 which is a Fedora approved license * The license matches the license statements in the source * The license file in the sources (gpl.txt) is packaged as %doc * The spec file is written in legible English * The source matches upstream and is the latest version ead0a8db5440e480c8a23441195a76df zyn-1.tar.bz2 ead0a8db5440e480c8a23441195a76df SRPM/zyn-1.tar.bz2 * Package builds in mock (Fedora 10) ? BuildRequires on jack-audio-connection-kit-devel - is it needed? * No shared libraries in the default library path ! Neither the package nor any of its Requires own %{_libdir}/lv2 (the other two plugin packages have Requires: lv2core) * No duplicate files * Permissions are sane and %files has %defattr * %clean clear buildroot * Macros are used consistently * Contains code * %doc is not essential at runtime * Package does not own other's directories * %install clears buildroot * Installed filenames are valid UTF-8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review