Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497338 --- Comment #2 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-04-23 11:19:09 EDT --- (In reply to comment #1) > +/- The package successfully compiles and builds into binary rpms on at least > one primary architecture. But only after adding numpy as BR: > > http://koji.fedoraproject.org/koji/taskinfo?taskID=1316865 > > - All build dependencies must be listed in BuildRequires, so, please add numpy. OK, sorry, didn't remember to test with mock :) Added numpy depedencies. > Definitely there are more missing runtime python dependencies - here is an > output of "find -name "*py" -exec grep import {} \; | sort|uniq": > > http://peter.fedorapeople.org/cclib_imports.txt > > Please, add all necessary runtime python dependencies. I don't think that there are any more, at least that's what the website says: http://cclib.sourceforge.net/wiki/index.php/Install At least they're not necessary for operation. > So, please add the only missign BuildRequire and all missing Requires. > > Also, I'm not sure, that we should ship *.pyc-files in %doc, however this is > not a blocker. Oh, thanks for picking this up. I forgot about it since at first I didn't get the tests working, but then figured out how to pass the additional library dir argument. http://theory.physics.helsinki.fi/~jzlehtol/rpms/python-cclib.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/python-cclib-0.91-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review