Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492927 Ivan Efremov <iefremov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iefremov@xxxxxxxxx --- Comment #1 from Ivan Efremov <iefremov@xxxxxxxxx> 2009-04-14 04:27:00 EDT --- It's only 'pre-review' since I can't be a sponsor. 1) license should be 'GPLv3+' (according to headers in source files) 2) why do you use 'pre-release' Release tag? consider changing 0.1 -> 1 http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Release 3) consider writing more detailed description 4) preserving timestamps: your Makefile must preserve timestamps using 'install -p' http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps 5) your package doesn't own the directory '%{_datadir}/xcowsay/', see http://fedoraproject.org/wiki/Packaging/UnownedDirectories 6) note about desktop file: MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. 7) consider adding man pages describing other binaries than xcowsay: xcowdream, xcowthink etc. Good luck! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review