Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490269 --- Comment #10 from Thibault North <thibault.north@xxxxxxxxx> 2009-04-13 11:34:26 EDT --- >- You didn't update release tag, even though you modified the spec file. Yup, since the package is not part of the repo yet, I tought that was not required at that point. >- Fix the rpmlint warning. Also, please don't use macros where they are not needed: rm, make, cp, mkdir &c. This makes the spec file unneededly difficult to read. Okay i'll fix that. >- Patch0 is highly dubitable since it is not necessary in order to build the package;[...] You're actually right, but this patch adds credits for another contributer also. While upstream hasn't updated its source archive, I wanted to be sure that this contributor is present in the AUTHORS file. But alright, i'll remove it and wait till it is present upstream. I'll fix all that within the next few day. Thanks again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review